masonhuang/cluster4npu
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: Ensure result callback is always set on pipeline regardless of result handler

Browse Source 
- Remove dependency on result_handler for setting pipeline result callback
- Always call result_callback when handle_result is triggered
- This fixes the issue where GUI callbacks weren't being called because
  output type 'display' wasn't supported, causing result_handler to be None
- Add more debug output to trace callback flow
This commit is contained in:
Masonmason 2025-07-23 22:43:42 +08:00
parent 2dec66edad
commit 18ec31738a
1 changed files with 24 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
cluster4npu_ui/core/functions/workflow_orchestrator.py
View File

@ -58,9 +58,10 @@ class WorkflowOrchestrator:
# Set the pipeline's put_data method as the callback # Set the pipeline's put_data method as the callback
self.data_source.set_data_callback(self.pipeline.put_data) self.data_source.set_data_callback(self.pipeline.put_data)
# Set the result callback on the pipeline # Set the result callback on the pipeline - always set this regardless of result_handler
if self.result_handler: # The handle_result method will decide what to do with the results
self.pipeline.set_result_callback(self.handle_result) self.pipeline.set_result_callback(self.handle_result)
print(f"🔍 ORCHESTRATOR DEBUG: Set result callback on pipeline")
# Start the pipeline # Start the pipeline
self.pipeline.initialize() self.pipeline.initialize()
@ -162,26 +163,32 @@ class WorkflowOrchestrator:
print(f"🔍 ORCHESTRATOR DEBUG: handle_result called with: {result_data}") print(f"🔍 ORCHESTRATOR DEBUG: handle_result called with: {result_data}")
print(f"🔍 ORCHESTRATOR DEBUG: result_callback is: {self.result_callback}") print(f"🔍 ORCHESTRATOR DEBUG: result_callback is: {self.result_callback}")
if self.result_handler: try:
try: # Convert PipelineData to a dictionary for serialization
# Convert PipelineData to a dictionary for serialization result_dict = {
result_dict = { "pipeline_id": result_data.pipeline_id,
"pipeline_id": result_data.pipeline_id, "timestamp": result_data.timestamp,
"timestamp": result_data.timestamp, "metadata": result_data.metadata,
"metadata": result_data.metadata, "stage_results": result_data.stage_results
"stage_results": result_data.stage_results }
}
# Save to file if result handler exists
if self.result_handler:
self.result_handler.save_result( self.result_handler.save_result(
result_dict, result_dict,
self.pipeline.pipeline_name, self.pipeline.pipeline_name,
format=self.output_config.get('format', 'json').lower() format=self.output_config.get('format', 'json').lower()
) )
# Also call the result callback if set # Always call the result callback if set (for GUI updates)
if self.result_callback: if self.result_callback:
self.result_callback(result_dict) print(f"🔍 ORCHESTRATOR DEBUG: Calling result_callback with: {result_dict}")
except Exception as e: self.result_callback(result_dict)
print(f"❌ Error handling result: {e}") else:
print(f"🔍 ORCHESTRATOR DEBUG: No result_callback set in orchestrator!")
except Exception as e:
print(f"❌ Error handling result: {e}")
def _parse_resolution(self, resolution_str: Optional[str]) -> Optional[tuple[int, int]]: def _parse_resolution(self, resolution_str: Optional[str]) -> Optional[tuple[int, int]]:
""" """