M8-10a smoke test 抓到 M1 就潛藏的 P0 latent bug:server 預設 dataDir = <binary>/data,bundle 內解析成 Contents/Resources/bin/data/(空目錄), 實際 models.json + 8 個 .nef 住在 Contents/Resources/data/(上一層)。 Wails 又傳 --data-dir 成 user home(writable),同樣沒 models.json。 結果任何正式啟動路徑下 /api/models 都回 total: 0,M1-M7 smoke 從沒 跑過這個 endpoint 才漏抓。 修法:把「read-only bundle 內資料」和「writable user 資料」語意拆開。 - 新增 findFirstExisting(candidates, sentinel) helper - 新增 resolveBuiltInDataDir:①VISIONA_BUNDLE_LIB_DIR/data(AppImage) ②<base>/data ③<base>/../data ④<base>/../Resources/data ⑤<base>/../lib/visiona-local/data(Linux FHS)。命中條件是 models.json 存在為 regular file,避開 Wails build artifact 留下的 空 data/ 目錄 - main() 拆 builtInDataDir(modelRepo + flash.Service 用)與 dataDir (custom-models / sentinel / logs 用),職責分明 - flash.NewService 改吃 builtInDataDir — 它要解析 models.json 裡的 相對路徑 "data/nef/kl520/xxx.nef",來源是 bundle 不是 user home - resolveBridgeScript 同步修(同樣的技術債一起清),候選 env var 優先 + FHS fallback,避免 Linux AppImage 上 kneron_bridge.py 也找不到 - fallback 全 filepath.Abs 化,log.Printf 印嘗試過的路徑清單便於除錯 驗證(build / vet / test + smoke)全綠: - macOS bundle:/api/models → 15 models ✅ - dev mode(server/ 下 go run):15 models ✅ - Linux AppImage 模擬 + env var:命中候選 1 ✅ - Linux AppImage 模擬 + 無 env var:命中候選 5(FHS)✅ - 全不命中:log 印完整 tried 清單 + server 不 crash ✅ Reviewer 兩輪通過。第一輪抓到 Linux AppImage 未覆蓋(Major-1)+ 2 Minor + 2 Suggestion;第二輪確認全部處理到位、新發現兩項非阻擋風格建議列為 技術債。報告見 .autoflow/05-implementation/reviews/review-m8-10a-*.md。 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
381 lines
14 KiB
Go
381 lines
14 KiB
Go
package main
|
||
|
||
import (
|
||
"context"
|
||
"errors"
|
||
"fmt"
|
||
"log"
|
||
"net"
|
||
"net/http"
|
||
"os"
|
||
"os/exec"
|
||
"os/signal"
|
||
"path/filepath"
|
||
"runtime"
|
||
"strings"
|
||
"syscall"
|
||
"time"
|
||
|
||
"visiona-local/server/internal/api"
|
||
"visiona-local/server/internal/api/handlers"
|
||
"visiona-local/server/internal/api/ws"
|
||
"visiona-local/server/internal/camera"
|
||
"visiona-local/server/internal/config"
|
||
"visiona-local/server/internal/deps"
|
||
"visiona-local/server/internal/device"
|
||
"visiona-local/server/internal/flash"
|
||
"visiona-local/server/internal/inference"
|
||
"visiona-local/server/internal/model"
|
||
pkglogger "visiona-local/server/pkg/logger"
|
||
"visiona-local/server/web"
|
||
)
|
||
|
||
var (
|
||
Version = "dev"
|
||
BuildTime = "unknown"
|
||
)
|
||
|
||
// baseDir returns the base directory for resolving data/ and scripts/ paths.
|
||
// In dev mode (go run), uses the working directory.
|
||
// In production (compiled binary), uses the binary's directory so the server
|
||
// works correctly regardless of the working directory.
|
||
func baseDir(devMode bool) string {
|
||
if devMode {
|
||
return "."
|
||
}
|
||
exe, err := os.Executable()
|
||
if err != nil {
|
||
return "."
|
||
}
|
||
return filepath.Dir(exe)
|
||
}
|
||
|
||
// findFirstExisting tries each candidate directory and returns the first one
|
||
// that contains `sentinel` as a regular file. Returned path is absolute.
|
||
//
|
||
// If no candidate hits, returns ("", tried) where `tried` is the absolute
|
||
// form of every candidate that was checked — callers can log this for
|
||
// debugging. Callers are expected to supply their own fallback value.
|
||
func findFirstExisting(candidates []string, sentinel string) (string, []string) {
|
||
tried := make([]string, 0, len(candidates))
|
||
for _, c := range candidates {
|
||
abs, err := filepath.Abs(c)
|
||
if err != nil {
|
||
tried = append(tried, c)
|
||
continue
|
||
}
|
||
tried = append(tried, abs)
|
||
if info, err := os.Stat(filepath.Join(abs, sentinel)); err == nil && !info.IsDir() {
|
||
return abs, tried
|
||
}
|
||
}
|
||
return "", tried
|
||
}
|
||
|
||
// resolveBridgeScript finds the directory holding kneron_bridge.py across
|
||
// different packaging layouts, then returns the absolute path to the script.
|
||
//
|
||
// Possible locations (tried in order):
|
||
// 1. <env VISIONA_BUNDLE_LIB_DIR>/scripts — Linux AppImage (AppRun exports this)
|
||
// 2. <base>/scripts — dev mode or flat layout
|
||
// 3. <base>/../scripts — Windows/Linux installer: {app}/bin/<exe>, {app}/scripts/
|
||
// 4. <base>/../Resources/scripts — macOS app bundle: Contents/Resources/bin/<exe>, Contents/Resources/scripts/
|
||
// 5. <base>/../lib/visiona-local/scripts — Linux AppImage FHS: usr/bin/<exe>, usr/lib/visiona-local/scripts/
|
||
// 6. ./scripts — cwd fallback
|
||
func resolveBridgeScript(base string) string {
|
||
candidates := []string{}
|
||
if libDir := os.Getenv("VISIONA_BUNDLE_LIB_DIR"); libDir != "" {
|
||
candidates = append(candidates, filepath.Join(libDir, "scripts"))
|
||
}
|
||
candidates = append(candidates,
|
||
filepath.Join(base, "scripts"),
|
||
filepath.Join(base, "..", "scripts"),
|
||
filepath.Join(base, "..", "Resources", "scripts"),
|
||
filepath.Join(base, "..", "lib", "visiona-local", "scripts"),
|
||
filepath.Join(".", "scripts"),
|
||
)
|
||
if dir, tried := findFirstExisting(candidates, "kneron_bridge.py"); dir != "" {
|
||
return filepath.Join(dir, "kneron_bridge.py")
|
||
} else {
|
||
log.Printf("warn: kneron_bridge.py not found. Tried: %v", tried)
|
||
}
|
||
// Fallback — return the default so downstream logs a clear error
|
||
abs, err := filepath.Abs(filepath.Join(base, "scripts", "kneron_bridge.py"))
|
||
if err != nil {
|
||
return filepath.Join(base, "scripts", "kneron_bridge.py")
|
||
}
|
||
return abs
|
||
}
|
||
|
||
// resolveBuiltInDataDir finds the bundle-internal data/ directory that ships
|
||
// with the binary. This directory is *read-only* at runtime and holds the
|
||
// built-in model catalog (models.json + nef/kl520/ + nef/kl720/).
|
||
//
|
||
// This is different from the user data directory (lock, ipc-port, logs,
|
||
// custom-models, preferences.json, sentinel file) which is writable and lives
|
||
// under the OS-specific app-data location. See main() for the split.
|
||
//
|
||
// Possible locations (tried in order):
|
||
// 1. <env VISIONA_BUNDLE_LIB_DIR>/data — Linux AppImage (AppRun exports this)
|
||
// 2. <base>/data — dev mode or flat layout (cwd == repo/server/)
|
||
// 3. <base>/../data — Windows/Linux installer: {app}/bin/<exe>, {app}/data/
|
||
// 4. <base>/../Resources/data — macOS app bundle: Contents/Resources/bin/<exe>, Contents/Resources/data/
|
||
// 5. <base>/../lib/visiona-local/data — Linux AppImage FHS: usr/bin/<exe>, usr/lib/visiona-local/data/
|
||
//
|
||
// A candidate counts as a hit only if models.json exists inside it as a
|
||
// regular file — this avoids false positives from empty `data/` directories
|
||
// that Wails sometimes leaves behind in build artifacts.
|
||
func resolveBuiltInDataDir(base string) string {
|
||
candidates := []string{}
|
||
if libDir := os.Getenv("VISIONA_BUNDLE_LIB_DIR"); libDir != "" {
|
||
candidates = append(candidates, filepath.Join(libDir, "data"))
|
||
}
|
||
candidates = append(candidates,
|
||
filepath.Join(base, "data"),
|
||
filepath.Join(base, "..", "data"),
|
||
filepath.Join(base, "..", "Resources", "data"),
|
||
filepath.Join(base, "..", "lib", "visiona-local", "data"),
|
||
)
|
||
if dir, tried := findFirstExisting(candidates, "models.json"); dir != "" {
|
||
return dir
|
||
} else {
|
||
log.Printf("warn: built-in data dir (models.json) not found. Tried: %v", tried)
|
||
}
|
||
// Fallback — return the default so downstream logs a clear error
|
||
abs, err := filepath.Abs(filepath.Join(base, "data"))
|
||
if err != nil {
|
||
return filepath.Join(base, "data")
|
||
}
|
||
return abs
|
||
}
|
||
|
||
func main() {
|
||
cfg := config.Load()
|
||
|
||
logger := pkglogger.New(cfg.LogLevel)
|
||
|
||
logger.Info("Starting visionA-local Server %s (built: %s)", Version, BuildTime)
|
||
logger.Info("Dev mode: %v, Python mode: %s", cfg.DevMode, cfg.PythonMode)
|
||
|
||
// 把 VISIONA_BUNDLE_BIN_DIR 加到 PATH,讓 exec.Command("ffmpeg") / exec.Command("ffprobe")
|
||
// 能透過 LookPath 找到 bundle 內的 binary(Go 1.19+ Windows 不再搜 cwd)。
|
||
if bundleBin := os.Getenv("VISIONA_BUNDLE_BIN_DIR"); bundleBin != "" {
|
||
sep := string(os.PathListSeparator)
|
||
os.Setenv("PATH", bundleBin+sep+os.Getenv("PATH"))
|
||
logger.Info("Added VISIONA_BUNDLE_BIN_DIR to PATH: %s", bundleBin)
|
||
}
|
||
|
||
// Check external dependencies
|
||
deps.PrintStartupReport(logger)
|
||
|
||
// Resolve base directory.
|
||
base := baseDir(cfg.DevMode)
|
||
|
||
// Resolve built-in data directory (read-only, ships with the binary).
|
||
// Holds models.json + nef/kl520/ + nef/kl720/. Auto-detected across
|
||
// dev / installer / macOS-bundle layouts; see resolveBuiltInDataDir().
|
||
builtInDataDir := resolveBuiltInDataDir(base)
|
||
logger.Info("Built-in data dir: %s", builtInDataDir)
|
||
|
||
// Resolve user data directory (writable). Holds lock, ipc-port, logs,
|
||
// custom-models, preferences.json, sentinel. Wails passes this via
|
||
// --data-dir pointing at the OS app-data location.
|
||
//
|
||
// Standalone fallback: when no --data-dir is given we reuse builtInDataDir
|
||
// so `go run ./server` and direct binary launches keep working for local
|
||
// development. In *production*, Wails always passes --data-dir, so this
|
||
// branch never lands on a read-only bundle path. If someone does run the
|
||
// packaged binary with no --data-dir, the writable operations (sentinel,
|
||
// logs, custom-models) will fail against the read-only bundle dir and the
|
||
// affected code paths log warnings — they don't crash the server.
|
||
dataDir := cfg.DataDir
|
||
if dataDir == "" {
|
||
dataDir = builtInDataDir
|
||
}
|
||
|
||
// Initialize model repository (built-in models from JSON).
|
||
// Always read from the built-in data dir — not the user data dir —
|
||
// so Wails passing --data-dir doesn't accidentally blank out the catalog.
|
||
modelRepo := model.NewRepository(filepath.Join(builtInDataDir, "models.json"))
|
||
logger.Info("Loaded %d built-in models", modelRepo.Count())
|
||
|
||
// Initialize model store (custom uploaded models) — writable, user dataDir.
|
||
customModelDir := cfg.ModelDir
|
||
if customModelDir == "" {
|
||
customModelDir = filepath.Join(dataDir, "custom-models")
|
||
}
|
||
modelStore := model.NewModelStore(customModelDir)
|
||
customModels, err := modelStore.LoadCustomModels()
|
||
if err != nil {
|
||
logger.Warn("Failed to load custom models: %v", err)
|
||
}
|
||
for _, m := range customModels {
|
||
modelRepo.Add(m)
|
||
}
|
||
if len(customModels) > 0 {
|
||
logger.Info("Loaded %d custom models", len(customModels))
|
||
}
|
||
|
||
// Initialize WebSocket hub (before device manager so log broadcaster is ready)
|
||
wsHub := ws.NewHub()
|
||
// M8-4b:注入 dataDir 給 Hub,第一個 WebSocket client 連上時會在
|
||
// <dataDir>/.first-ws-connected 寫 sentinel file,讓 Wails 端的
|
||
// StartupPipeline 知道階段 6(Wait for Web UI WebSocket)已完成。
|
||
// 詳見 .autoflow/04-architecture/v2/startup-pipeline.md §3 階段 6。
|
||
wsHub.SetStartupSentinel(dataDir)
|
||
go wsHub.Run()
|
||
|
||
// Initialize log broadcaster for real-time log streaming
|
||
logBroadcaster := pkglogger.NewBroadcaster(500, func(entry pkglogger.LogEntry) {
|
||
wsHub.BroadcastToRoom("server-logs", entry)
|
||
})
|
||
logger.SetBroadcaster(logBroadcaster)
|
||
|
||
// Initialize device manager
|
||
registry := device.NewRegistry()
|
||
bridgeScript := resolveBridgeScript(base)
|
||
logger.Info("Kneron bridge script: %s", bridgeScript)
|
||
deviceMgr := device.NewManager(registry, bridgeScript)
|
||
deviceMgr.SetLogBroadcaster(logBroadcaster)
|
||
deviceMgr.Start()
|
||
|
||
// Initialize camera manager
|
||
cameraMgr := camera.NewManager()
|
||
|
||
// Initialize services.
|
||
// flash.Service resolves relative `.nef` paths from models.json against
|
||
// builtInDataDir (not dataDir), since the .nef files ship alongside
|
||
// models.json in the read-only bundle, not in the writable user dataDir.
|
||
flashSvc := flash.NewService(deviceMgr, modelRepo, builtInDataDir)
|
||
inferenceSvc := inference.NewService(deviceMgr)
|
||
|
||
// Determine static file system for embedded frontend
|
||
var staticFS http.FileSystem
|
||
if !cfg.DevMode {
|
||
staticFS = web.StaticFS()
|
||
logger.Info("Serving embedded frontend static files")
|
||
} else {
|
||
logger.Info("Dev mode: frontend static serving disabled (use Wails dev server)")
|
||
}
|
||
|
||
// Build HTTP server (needed for graceful shutdown and restart)
|
||
var httpServer *http.Server
|
||
restartRequested := make(chan struct{}, 1)
|
||
|
||
shutdownFn := func() {
|
||
// MAJ-3 修復:timeout 必須 ≤ Wails shutdownGracePeriod (7s),留 1s buffer。
|
||
// TDD §8.1:Wails 端 7s grace + 1s modal;server 端 6s 內必須完成清理,
|
||
// 否則 Wails 在第 7s SIGKILL 時 server 還在 sync 檔案會被打斷。
|
||
ctx, cancel := context.WithTimeout(context.Background(), 6*time.Second)
|
||
defer cancel()
|
||
inferenceSvc.StopAll()
|
||
cameraMgr.Close()
|
||
if httpServer != nil {
|
||
_ = httpServer.Shutdown(ctx)
|
||
}
|
||
}
|
||
|
||
restartFn := func() {
|
||
// Signal the main goroutine to perform exec after server shutdown
|
||
select {
|
||
case restartRequested <- struct{}{}:
|
||
default:
|
||
}
|
||
shutdownFn()
|
||
}
|
||
|
||
// Resolve python bin (used by InstallDriver handler on Windows).
|
||
// Priority: VISIONA_PYTHON env var (set by Wails shell) → cfg.PythonBin (--python flag)
|
||
pythonBinForSystem := os.Getenv("VISIONA_PYTHON")
|
||
if pythonBinForSystem == "" {
|
||
pythonBinForSystem = cfg.PythonBin
|
||
}
|
||
|
||
// Create system handler with injected version and restart function
|
||
systemHandler := handlers.NewSystemHandler(Version, BuildTime, pythonBinForSystem, restartFn, wsHub)
|
||
|
||
// Create router
|
||
r := api.NewRouter(modelRepo, modelStore, deviceMgr, cameraMgr, flashSvc, inferenceSvc, wsHub, staticFS, logBroadcaster, systemHandler)
|
||
|
||
// Configure HTTP server (bind to localhost only)
|
||
addr := cfg.Addr()
|
||
httpServer = &http.Server{
|
||
Addr: addr,
|
||
Handler: r,
|
||
}
|
||
|
||
// Handle OS signals for graceful shutdown
|
||
quit := make(chan os.Signal, 1)
|
||
signal.Notify(quit, syscall.SIGINT, syscall.SIGTERM)
|
||
go func() {
|
||
sig := <-quit
|
||
logger.Info("Received signal %v, shutting down gracefully...", sig)
|
||
shutdownFn()
|
||
os.Exit(0)
|
||
}()
|
||
|
||
// Kill existing process on the port if occupied
|
||
killExistingProcess(addr, logger)
|
||
|
||
// Start server
|
||
logger.Info("Server listening on %s", addr)
|
||
if err := httpServer.ListenAndServe(); err != nil && !errors.Is(err, http.ErrServerClosed) {
|
||
log.Fatalf("Failed to start server: %v", err)
|
||
}
|
||
|
||
// If restart was requested, exec the same binary to replace this process
|
||
select {
|
||
case <-restartRequested:
|
||
logger.Info("Performing self-restart via exec...")
|
||
exe, err := os.Executable()
|
||
if err != nil {
|
||
log.Fatalf("Failed to get executable path: %v", err)
|
||
}
|
||
exe, err = filepath.EvalSymlinks(exe)
|
||
if err != nil {
|
||
log.Fatalf("Failed to resolve executable symlinks: %v", err)
|
||
}
|
||
_ = syscall.Exec(exe, os.Args, os.Environ())
|
||
log.Fatalf("syscall.Exec failed")
|
||
default:
|
||
// Normal shutdown, just exit
|
||
}
|
||
}
|
||
|
||
// killExistingProcess checks if the port is already in use and kills the
|
||
// occupying process so the server can start cleanly.
|
||
func killExistingProcess(addr string, logger *pkglogger.Logger) {
|
||
// Extract port from addr (e.g. "127.0.0.1:3721" → "3721")
|
||
_, port, err := net.SplitHostPort(addr)
|
||
if err != nil {
|
||
return
|
||
}
|
||
|
||
// Quick check: try to listen — if it works, port is free
|
||
ln, err := net.Listen("tcp", addr)
|
||
if err == nil {
|
||
ln.Close()
|
||
return
|
||
}
|
||
|
||
// Port is occupied, find and kill the process
|
||
logger.Info("Port %s is in use, killing existing process...", port)
|
||
|
||
var cmd *exec.Cmd
|
||
if runtime.GOOS == "windows" {
|
||
cmd = exec.Command("cmd", "/C", fmt.Sprintf("for /f \"tokens=5\" %%a in ('netstat -ano ^| findstr :%s') do taskkill /F /PID %%a", port))
|
||
} else {
|
||
cmd = exec.Command("sh", "-c", fmt.Sprintf("lsof -ti:%s | xargs kill -9 2>/dev/null", port))
|
||
}
|
||
|
||
output, err := cmd.CombinedOutput()
|
||
if err != nil {
|
||
logger.Warn("Failed to kill process on port %s: %v (%s)", port, err, strings.TrimSpace(string(output)))
|
||
return
|
||
}
|
||
|
||
// Wait briefly for port to be released
|
||
time.Sleep(500 * time.Millisecond)
|
||
logger.Info("Previous process killed, port %s is now free", port)
|
||
}
|